Skip to content

fix: LSP4E DeleteParticipant fails with FileSystemNotFoundException for custom EFS URI schemes #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StefanFu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: LSP4E DeleteParticipant fails with FileSystemNotFoundException for custom EFS URI schemes #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion org.eclipse.lsp4e/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: Language Server Protocol client for Eclipse IDE (Incubation)
Bundle-SymbolicName: org.eclipse.lsp4e;singleton:=true
Bundle-Version: 0.19.13.qualifier
Bundle-Version: 0.19.14.qualifier
Bundle-RequiredExecutionEnvironment: JavaSE-21
Require-Bundle: org.eclipse.core.runtime;bundle-version="3.12.0",
org.eclipse.equinox.common;bundle-version="3.8.0",
Expand Down
2 changes: 1 addition & 1 deletion org.eclipse.lsp4e/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</parent>
<artifactId>org.eclipse.lsp4e</artifactId>
<packaging>eclipse-plugin</packaging>
<version>0.19.13-SNAPSHOT</version>
<version>0.19.14-SNAPSHOT</version>

<build>
<plugins>
Expand Down
11 changes: 10 additions & 1 deletion ...pse.lsp4e/src/org/eclipse/lsp4e/operations/rename/LSPFileOperationParticipantSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
*******************************************************************************/
package org.eclipse.lsp4e.operations.rename;

import java.nio.file.FileSystemNotFoundException;
import java.nio.file.Path;
import java.util.List;
import java.util.Objects;
Expand Down Expand Up @@ -117,7 +118,15 @@ public static LanguageServerProjectExecutor createFileOperationExecutor(final IR
return LanguageServers.forProject(project).withFilter(capabilities -> false);
}

final var path = Path.of(uri);
Path path;

try {
Comment thread
StefanFu marked this conversation as resolved.
path = Path.of(uri);
} catch (FileSystemNotFoundException | IllegalArgumentException e) {
// Not an NIO path, so we cannot match any file operation filters
return LanguageServers.forProject(project).withFilter(capabilities -> false);
}

return LanguageServers.forProject(project).withFilter(capabilities -> {
final var workspace = capabilities.getWorkspace();
if (workspace == null)
Expand Down