Skip to content

Adopt LSPHoverRegion introduction #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BoykoAlex wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adopt LSPHoverRegion introduction #1564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e610a2b
Adopt LSPHoverRegion introduction
BoykoAlex Jul 28, 2026
3d65ba7
Bump up bundle version
BoykoAlex Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion org.eclipse.lsp4e.jdt/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: JDT Integration for LSP4E
Bundle-SymbolicName: org.eclipse.lsp4e.jdt;singleton:=true
Bundle-Version: 0.14.2.qualifier
Bundle-Version: 0.14.3.qualifier
Export-Package: org.eclipse.lsp4e.jdt
Automatic-Module-Name: org.eclipse.lsp4e.jdt
Bundle-Activator: org.eclipse.lsp4e.jdt.LanguageServerJdtPlugin
Expand Down
5 changes: 3 additions & 2 deletions org.eclipse.lsp4e.jdt/src/org/eclipse/lsp4e/jdt/LSJavaHoverProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2017, 2020 Pivotal Inc. and others.
* Copyright (c) 2017, 2026 Pivotal Inc. and others.
* This program and the accompanying materials are made
* available under the terms of the Eclipse Public License 2.0
* which is available at https://www.eclipse.org/legal/epl-2.0/
Expand Down Expand Up @@ -47,7 +47,8 @@ public class LSJavaHoverProvider extends JavadocHover {
if (textViewer == null || hoverRegion == null) {
return null;
}
CompletableFuture<@Nullable String> lsHoverFuture = this.lsBasedHover.getHoverInfoFuture(textViewer, hoverRegion);
IRegion lsHoverRegion = getHoverRegion(textViewer, hoverRegion.getOffset());
CompletableFuture<@Nullable String> lsHoverFuture = this.lsBasedHover.getHoverInfoFuture(textViewer, lsHoverRegion == null ? hoverRegion : lsHoverRegion);
final var lsHtmlHoverContent = new AtomicReference<@Nullable String>();
final var jdtHoverControlInput = new AtomicReference<@Nullable JavadocBrowserInformationControlInput>();

Expand Down
Loading