Skip to content

Conversation

@cshannon2
Copy link
Contributor

No description provided.

Copy link
Contributor

@jabrah jabrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For an initial commit, this should be OK.

We'll need to touch all of the workflows mentioned here and add on.workflow_call that will look similar to on.workflow_dispatch (https://docs.github.com/en/actions/using-workflows/reusing-workflows#creating-a-reusable-workflow).

After that, we'll need to make sure releases are ordered and timed correctly. Will need to find a reasonable way of waiting on Java releases for their release artifacts to be available in Maven Central, but we can figure that out in subsequent iterations as long as it's understood that we can't use this workflow until all of those are taken care of.

@jabrah jabrah mentioned this pull request Jun 28, 2023
@jabrah
Copy link
Contributor

jabrah commented Jun 28, 2023

The initial draft was pretty close. The Java release portions were the only ones that need to be rewritten as a stand-alone workflow to support local/offline dependency resolution (though currently untested). Some explicit job dependencies were also called out to allow several jobs to run concurrently to help speed things along

@jabrah jabrah changed the title Initial commit to release all Eclipse projects from one action Release all Eclipse projects from one action Jun 28, 2023
@cshannon2
Copy link
Contributor Author

Do we need to use the offline flag in order to use the maven builds that aren't currently in maven central? Can we make a template for the individual steps / refactor while also keeping the local builds in one single environment for the dependencies to access?

@jabrah
Copy link
Contributor

jabrah commented Jul 24, 2023

Will need release workflows to be externally callable (adding workflow_call along side workflow_dispatch):

We'll need to determine the scoping of the GH provided token, whether we need to add specific credentials for letting the external workflows make commits in their respective repositories.

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarqubecloud
Copy link

@markpatton
Copy link
Contributor

No longer relevant.

@markpatton markpatton closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Release Automation workflows to deploy a new release to the AWS Pass Demo instance

4 participants