Add Rectangle.of(Point,Point) supporting OfFloat #2907
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1 task
akoch-yatta
reviewed
Dec 23, 2025
| * @since 3.133 | ||
| */ | ||
| public static Rectangle of(Point topLeft, Point dimension) { | ||
| if(dimension instanceof Point.OfFloat ofFloatDimension) { |
Contributor
There was a problem hiding this comment.
I think we need to extend this PR a bit:
- spacing between if
- we need to handle the case when top is a Point.OfFloat as well for consistency
- And we should add some tests for the four different possible cases, so (Point, Point), (Point.OfFloat, Point), (Point, Point.OfFloat) and (Point.OfFloat, Point.OfFloat)
When the size point is Point.OfFloat, return Rectangle.OfFloat to retain sub-pixel precision; otherwise return the classic Rectangle.
ShahzaibIbrahim
force-pushed
the
master-563
branch
from
1af9dbf to
c5eba4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the size point is Point.OfFloat, return Rectangle.OfFloat to retain sub-pixel precision; otherwise return the classic Rectangle.
This is introduced as needed to be used in eclipse-platform/eclipse.platform.ui#3597