docs: design custom metrics collection path for node-level resource monitoring#521
Draft
Chulhee1Lee with Copilot wants to merge 2 commits into
Draft
docs: design custom metrics collection path for node-level resource monitoring#521Chulhee1Lee with Copilot wants to merge 2 commits into
Chulhee1Lee with Copilot wants to merge 2 commits into
Conversation
10 tasks
Add LLD design documents for custom metrics collection path in MonitoringServer. Documents cover: - Analysis of existing StressMonitoringMetric gRPC path (App → MonitoringServer → etcd) - Gap analysis: missing MonitoringServer → PolicyManager forwarding - Design direction for extending policymanager.proto with CustomMetric - Two design options (extend existing RPC vs new dedicated RPC) - FPS metric example and policy definition structure - SettingsService REST API extension proposal Closes #520
Copilot
AI
changed the title
[WIP] Investigate and design custom metrics collection path
docs: design custom metrics collection path for node-level resource monitoring
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue investigated whether Pullpiri's MonitoringServer could collect application-specific custom metrics (FPS, Latency) and deliver them to PolicyManager. The result: the App→MonitoringServer→etcd path already exists via
StressMonitoringMetric, but the MonitoringServer→PolicyManager forwarding link is missing.Findings
Existing (implemented):
SendStressMonitoringMetricgRPC RPC inMonitoringServerConnectionwith JSON payload supportingfps,latency,cpu_loadsprocess_stress_requests()loop in manager persists to etcd at/pullpiri/metrics/stress/{process}/{pid}Missing (gaps):
ReportNodeMetricsRequestonly carriesNodeInfoDesign Documents Added
doc/architecture/EN/LLD/custom_metrics.mdanddoc/architecture/KR/LLD/custom_metrics.mdcover:ReportNodeMetricsRequestwith arepeated CustomMetric custom_metricsfieldReportCustomMetricsRPC, decoupled from system metric cadenceCustomMetricinterface definition —process_name,container_name,metric_name,metric_unit,value,timestamp_msGET /api/v1/metrics/custom) using the already-implementedget_all_stress_metrics()Design decision points (Option A vs B, batch vs immediate, structured vs JSON payload) are left for maintainer review.