Add logging for configuration parsing failures #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecasal
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
…t undefined behavior during partial construction
LittleHuba
reviewed
Nov 28, 2025
score/mw/com/impl/configuration/lola_service_instance_deployment.cpp
Outdated
Show resolved
Hide resolved
score/mw/com/impl/configuration/configuration_common_resources.h
Outdated
Show resolved
Hide resolved
jorgecasal
force-pushed
the
feature/issue-92-config-parsing-logging
branch
2 times, most recently
from
ae9de28 to
2179e1d
Compare
LittleHuba
reviewed
Dec 1, 2025
score/mw/com/impl/configuration/configuration_common_resources.h
Outdated
Show resolved
Hide resolved
score/mw/com/impl/configuration/configuration_common_resources.h
Outdated
Show resolved
Hide resolved
jorgecasal
force-pushed
the
feature/issue-92-config-parsing-logging
branch
from
2179e1d to
210ed06
Compare
LittleHuba
added
the
import-started-do-not-modify
Contributor
|
Your PR faces issues during integration. We are investigating currently and will get back to you if we require input from your side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements issue #92: "Print log message if Configuration parsing fails". It adds explicit logging and error handling to configuration parsing operations, replacing silent assertions with informative error messages before termination.
resolves #92