clippy: added clippy support #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for running clippy checks Addresses: eclipse-score/score#2008 Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
dcalavrezo-qorix
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
Member
|
warnings/errors on the build job? |
Addresses: eclipse-score/score#2008 Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
pawelrutkaq
reviewed
Dec 12, 2025
Contributor
pawelrutkaq
left a comment
pawelrutkaq
left a comment
There was a problem hiding this comment.
I have not looked into "old rust api".
| tags = ["manual"], | ||
| tags = [ | ||
| "manual", | ||
| "no-clippy", |
| srcs = ["ipc_bridge_gen.rs"], | ||
| visibility = [ | ||
| "//score/mw/com:__subpackages__", | ||
| "//visibility:public", |
Contributor
There was a problem hiding this comment.
maybe the subpackages visibility shall be changed to public in module only ? I guess most of them shall not be public as such for external consumers.
Changed the visibility after PR review Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
LittleHuba
requested changes
Dec 15, 2025
Contributor
LittleHuba
left a comment
LittleHuba
left a comment
There was a problem hiding this comment.
Please switch you approach to use rules_lint clippy instead.
This is the preferred way of integrating linters with bazel.
https://github.com/aspect-build/rules_lint/blob/79afc5ce25f55e918a93ef66ed81163423cdf632/example/tools/lint/linters.bzl#L6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for running clippy checks
Addresses: eclipse-score/score#2008