Add unit test in skeleton_event.h for checking timestamp #87 #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShoroukRamzy
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
ShoroukRamzy
changed the title
Author
|
Hi @LittleHuba , @castler and @hoe-jo, Could you please let me know your feedbacks and help me merge this PR if possible? I don't have sufficient permissions to merge. Thanks! |
ShoroukRamzy
force-pushed
the
skeleton-event-ts-test
branch
from
3b60016 to
11eccb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @LittleHuba,
This PR resolves issue #87 and verifies that SkeletonEvent::Send correctly updates the timestamp in the shared memory control data.
Thanks!