Use ARM64 and AMD64 Builders #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cross-building the arm64 container on amd64 is really slow, and the tests have not been executed on arm64 until now. Here, we start using an arm64 builder to avoid cross-building and to allow for running tests on both image variants before publication.
Contributor
Author
|
Builds have been validated on my personal fork, as usual (since they must run on main, and on a tag): |
AlexanderLanin
approved these changes
Nov 24, 2025
olivembo
reviewed
Nov 24, 2025
| # We do not use the push feature of devcontainers/ci here, since that would push the wrong container. | ||
| # Instead, we use the publish script which pushes the correct container (residing in src/s-core-devcontainer). | ||
| # manually login to ghcr.io for publishing | ||
| echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin |
There was a problem hiding this comment.
Do you need to manually login, since you have the login action above?
Contributor
Author
There was a problem hiding this comment.
I think yes, but I can double-check next time I create a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-building the
arm64container onamd64is really slow, and the tests have not been executed onarm64until now. Here, we start using anarm64builder to avoid cross-building and to allow for running tests on both image variants before publication.Closes #44