Skip to content

Conversation

@opajonk
Copy link
Contributor

@opajonk opajonk commented Nov 27, 2025

Some tools (specifically PlantUML in this case) require a JDK, hence we install it. Bazel's rules_java requires that JAVA_HOME is set appropriately, so we do that as well.

@opajonk opajonk marked this pull request as ready for review November 27, 2025 14:05
@AlexanderLanin
Copy link
Member

Does it make sense to install the jdk? As bazel will do it redundantly anyway

@AlexanderLanin
Copy link
Member

@opajonk
Copy link
Contributor Author

opajonk commented Nov 27, 2025

Does it make sense to install the jdk? As bazel will do it redundantly anyway

Bazel actually used the JAVA_HOME environment variable. And then it complained, that I installed only a JRE :-)

@opajonk
Copy link
Contributor Author

opajonk commented Nov 27, 2025

And if so, we need to discuss the exact version. Compare https://github.com/eclipse-score/dash-license-scan/blob/607e8f1879d9856e812746aa1a190bb0b598187a/src/dash_license_scan/jar.py#L31

No need to discuss, I can change it to 21.

@opajonk opajonk closed this Nov 27, 2025
@opajonk opajonk reopened this Nov 27, 2025
Some tools (specifically PlantUML in this case) require a JDK, hence we install it. Bazel's rules_java requires that JAVA_HOME is set appropriately, so we do that as well.
@opajonk opajonk changed the title Add Java Development Environment 17 Add Java Development Environment 21 Nov 27, 2025
@AlexanderLanin
Copy link
Member

It's still jdk vs jre. And I still wonder why it's needed. Bazel will download it's own version anyway... which is 17 by the way 😆

https://github.com/eclipse-score/reference_integration/blob/af717c2ea97aef3f5363b652ce36672b78dbaf76/.bazelrc#L58-L61

@opajonk
Copy link
Contributor Author

opajonk commented Nov 27, 2025

It's still jdk vs jre.

Well now I am installing the JDK. Bazel was complaining that the Java in JAVA_HOME was a JRE :-) So, I think it is using it after all?

@AlexanderLanin
Copy link
Member

As discussed we want to move tooling from bazel to devcontainer. So let's include java.

Optimizing jdk to jre is a separate topic.

@AlexanderLanin AlexanderLanin merged commit a679284 into eclipse-score:main Nov 28, 2025
4 checks passed
@opajonk opajonk deleted the add_jre branch November 28, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants