Fix: README.md and directory #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License Check Results🚀 The license check preparation job ran successfully. Status: Click to expand output |
Member
Author
|
This is not final proposal for change, it's more showcase in which direction to go. Open topics to cover:
|
License Check Results🚀 The license check preparation job ran successfully. Status: Click to expand output |
License Check Results🚀 The license check preparation job ran successfully. Status: Click to expand output |
README.md
Outdated
Comment on lines
21
to
19
| | `examples/` | Examples how to invoke targets of the module | | ||
| | `src/` | Source files for the module | |
Member
There was a problem hiding this comment.
As this will be used as a template, does it make sense to have an "examples" directory which will end up in each module? Shouldn't we rather provide an empty main.cpp in src?
On the other hand having a prefilled src directory is also inconvenient, as it might lead to merge conflicts when we update our hello world in the template.
Member
Author
There was a problem hiding this comment.
Agree. We do not need example folder and yes prefilled src directory can lead to certain issues. Keep it empty?
Member
We have not touched these topics yet. We should start those discussions soonish. Well, as soon as anyone has time to work on something here. Let's address them one by one?! |
Member
Author
Should I maybe open Issues where we can discuss each topic? |
License Check Results🚀 The license check preparation job ran successfully. Status: Click to expand output |
License Check Results🚀 The license check preparation job ran successfully. Status: Click to expand output |
nradakovic
force-pushed
the
nira_mt
branch
2 times, most recently
from
9ab2eae to
f478cdc
Compare
License Check Results🚀 The license check preparation job ran successfully. Status: Click to expand output |
License Check Results🚀 The license check preparation job ran successfully. Status: Click to expand output |
License Check Results🚀 The license check preparation job ran successfully. Status: Click to expand output |
The current proposal doesn't work with provided instructions.
License Check Results🚀 The license check preparation job ran successfully. Status: Click to expand output |
AlexanderLanin
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current proposal doesn't work with provided instructions.