-
Notifications
You must be signed in to change notification settings - Fork 21
adding test cases for snapshot scenario #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
adding test cases for snapshot scenario #190
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR extends the existing KVS snapshot test coverage by enabling Python tests to run against both Rust and C++ implementations. The changes add C++ test scenarios that parallel the Python snapshot tests, along with helper utilities for parameter parsing and KVS instance creation.
Key Changes:
- Extended Python test parametrization to include "cpp" alongside "rust"
- Added C++ implementations for four snapshot test scenarios with known failing cases marked via
pytest.xfail - Created helper utilities for parsing KVS parameters from JSON and managing KVS instances
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/python_test_cases/tests/test_cit_snapshots.py | Added "cpp" to test parametrization and marked known failures with xfail references |
| tests/cpp_test_scenarios/src/main.cpp | Integrated snapshot test group into the test harness |
| tests/cpp_test_scenarios/src/helpers/kvs_parameters.hpp | New helper for parsing KVS parameters from JSON input |
| tests/cpp_test_scenarios/src/helpers/kvs_instance.hpp | New helper for creating KVS instances from parsed parameters |
| tests/cpp_test_scenarios/src/cit/test_snapshots.hpp | Declaration of four snapshot test scenario classes |
| tests/cpp_test_scenarios/src/cit/test_snapshots.cpp | Implementation of snapshot test scenarios (count, max_count, restore, paths) |
| tests/cpp_test_scenarios/BUILD | Updated build configuration to use glob for source files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c920f42 to
3ff4b3d
Compare
ad66d5e to
d5afe29
Compare
This PR adds comprehensive C++ test coverage for KVS (Key-Value Store) snapshot functionality, enabling the existing Python test suite to run against both Rust and C++ implementations. The changes introduce new C++ test scenarios that mirror the Python snapshot tests, along with necessary helper utilities for KVS parameter parsing and instance creation.
Key Changes: