testing: Unify component integration tests structure #199

igorostrowskiq · 2025-12-16T16:34:00Z

No description provided.

github-actions · 2025-12-16T16:34:56Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 39253aae-215f-41f8-837c-5a4b8c3994f5
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 5 packages loaded
Loading: 5 packages loaded
    currently loading: 
Analyzing: target //:license-check (6 packages loaded, 0 targets configured)
Analyzing: target //:license-check (6 packages loaded, 0 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (117 packages loaded, 196 targets configured)

Analyzing: target //:license-check (156 packages loaded, 2668 targets configured)

Analyzing: target //:license-check (162 packages loaded, 3014 targets configured)

Analyzing: target //:license-check (165 packages loaded, 5021 targets configured)

INFO: Analyzed target //:license-check (165 packages loaded, 5030 targets configured).
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 62 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.644s, Critical Path: 0.41s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2025-12-16T16:36:59Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

This PR standardizes the naming and structure of component integration tests across the repository. The main changes include:

Renaming test directories from language-prefixed names (rust_test_scenarios, cpp_test_scenarios, python_test_cases) to a unified structure under tests/test_scenarios/{language} and tests/test_cases
Updating all build files, configuration files, and documentation to reference the new paths
Removing language prefixes from binary and package names for consistency

Reviewed changes

Copilot reviewed 16 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/test_scenarios/rust/Cargo.toml	Renamed package from `rust_test_scenarios` to `test_scenarios`
tests/test_scenarios/rust/BUILD	Updated binary name and visibility path to reflect new directory structure
tests/test_scenarios/cpp/src/test_basic.cpp	Updated namespace reference and reformatted braces (Allman style)
tests/test_scenarios/cpp/BUILD	Renamed binary from `cpp_test_scenarios` to `test_scenarios`
tests/test_cases/tests/conftest.py	Updated default target paths to new directory structure
tests/test_cases/requirements.txt.orig	Contains unresolved merge conflict markers
tests/test_cases/pyproject.toml	Renamed project from `python_test_cases` to `test_cases`
tests/test_cases/BUILD	Updated all target paths and comments to reference new structure
tests/integration_test_scenarios/init_rpi4.build	Updated commented path for QNX rust scenarios
tests/integration_test_scenarios/BUILD	Updated commented paths for QNX rust scenarios
tests/README.md	Updated all documentation paths and commands to reflect new structure
src/cpp/src/BUILD	Updated visibility path for test scenarios
MODULE.bazel	Updated requirements lock file path
Cargo.toml	Updated workspace member path
BUILD	Updated test suite target paths
.github/workflows/component_integration_tests.yml	Updated all workflow paths to new structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/test_cases/requirements.txt.orig

tests/README.md

Copilot

Pull request overview

Copilot reviewed 15 out of 40 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PiotrKorkus · 2025-12-16T20:52:33Z

tests/test_cases/pyproject.toml

correct location should be in repo root. Content of the file can be extended with options to pytest, ruff etc. Check kyron repo

PiotrKorkus · 2025-12-16T20:58:17Z

tests/test_cases/pytest.ini

imho, PYTHONPATH should be added and . removed from import statements in test files

PiotrKorkus · 2025-12-18T14:00:57Z

.github/workflows/component_integration_tests.yml


      - name: Run Python tests with pytest
-        working-directory: tests/python_test_cases
+        working-directory: tests/test_cases


remove this line, calling pytest from repo root will secure auto discovery and loading pyproject.toml correctly

PiotrKorkus · 2025-12-18T14:01:15Z

.github/workflows/component_integration_tests.yml

+        working-directory: tests/test_cases
        run: |
          python -m venv .venv
          source .venv/bin/activate
-          pip install .
+          pip install -r requirements.txt


we can make venv in repo root

PiotrKorkus · 2025-12-18T14:09:35Z

pyproject.toml

+skip-magic-trailing-comma = false
+
+# Like Black, automatically detect the appropriate line ending.
+line-ending = "auto"


empty line pls

PiotrKorkus · 2025-12-18T14:10:47Z

pyproject.toml

+[tool.pytest]
+addopts = ["-v"]
+pythonpath = [
+    "tests/test_cases",


did you check if tests/test_cases/tests is not needed when running pytest from repo root?

Right, it is not working when cwd is a root. Added required path.

PiotrKorkus · 2025-12-18T14:54:58Z

.github/workflows/component_integration_tests.yml

+        working-directory: tests/test_cases
        run: |
          source .venv/bin/activate
          python -m pytest


add --traces=all

PiotrKorkus

lgtm

igorostrowskiq · 2025-12-19T13:48:23Z

Squashed commits

igorostrowskiq requested a review from Copilot December 16, 2025 16:34

igorostrowskiq force-pushed the igorostrowskiq_unify_cit_structure branch from 3e28bc9 to 9b6691f Compare December 16, 2025 16:44

igorostrowskiq requested a review from PiotrKorkus December 16, 2025 16:51

Copilot AI reviewed Dec 16, 2025

View reviewed changes

tests/test_cases/requirements.txt.orig Outdated Show resolved Hide resolved

tests/README.md Outdated Show resolved Hide resolved

igorostrowskiq force-pushed the igorostrowskiq_unify_cit_structure branch from 9b6691f to 7fbf983 Compare December 16, 2025 17:47

igorostrowskiq requested a review from Copilot December 16, 2025 17:51

Copilot AI reviewed Dec 16, 2025

View reviewed changes

PiotrKorkus reviewed Dec 16, 2025

View reviewed changes

PiotrKorkus reviewed Dec 18, 2025

View reviewed changes

PiotrKorkus approved these changes Dec 19, 2025

View reviewed changes

testing: Unify component integration tests structure

a9130f3

igorostrowskiq force-pushed the igorostrowskiq_unify_cit_structure branch from 01ef5d7 to a9130f3 Compare December 19, 2025 13:48

testing: Unify component integration tests structure #199

Are you sure you want to change the base?

testing: Unify component integration tests structure #199

Uh oh!

Conversation

igorostrowskiq commented Dec 16, 2025

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Dec 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PiotrKorkus left a comment

Choose a reason for hiding this comment

Uh oh!

igorostrowskiq commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 16, 2025 •

edited

Loading