Conversation
boaks
force-pushed
the
cleanup_cookie
branch
3 times, most recently
from
db0f999 to
e599c28
Compare
obgm
reviewed
Jul 27, 2023
| *cookie = msg + sizeof(uint8); | ||
| return dtls_uint8_to_int(msg); | ||
| *cookie = msg; | ||
| return cookie_len; |
Contributor
There was a problem hiding this comment.
Odd: I would have expected a warning because of the cast from size_t to int. Maybe the compiler is smarter than I gave it credit for.
Otherwise: LGTM
Signed-off-by: Achim Kraus <achim.kraus@cloudcoap.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As preview for the cleanup using SKIP_VAR_FIELDS and GET_VAR_FIELDS.