Replace apacheds-protocol-dns with mock Netty dns server in tests #5845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
As I am not particularly familiar with DNS protocol so there might be oversights. |
Member
|
thanks for contributing this, I'll have a look |
Member
|
rebased on master |
Member
|
@pendula95 some tests are failing, can you address them ? |
pendula95
force-pushed
the
mock-dns-server
branch
from
b6a5554 to
da32819
Compare
Contributor
Author
|
I had a problem syncing branches so I made mistake, there is a new pull request #5871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5819