enable per-channel location weight scaling#2293
Draft
jpolz wants to merge 2 commits into
Draft
Conversation
clessig
reviewed
May 29, 2026
Collaborator
clessig
left a comment
There was a problem hiding this comment.
For me the concept of a fractional location weight is strange since it corrects for something that is either there or not. I see why one might want to control the weighting but conceptually it is still questionable.
In terms of the config, the pattern matching is problematic e.g. for z. So having an explicit list with all channels explicitly and the explicit weights is much preferable.
| # apply point weighting | ||
| if weights_points is not None: | ||
| kcrps_locs_chs = kcrps_locs_chs * weights_points | ||
| if weights_points.dim() == 1: |
Collaborator
There was a problem hiding this comment.
Can't we handle this without and if by broadcasting the shape in the uniform case?
| ) | ||
| if weights_points is not None: | ||
| diff_p = (diff_p.transpose(1, 0) * weights_points).transpose(1, 0) | ||
| if weights_points.dim() == 1: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backward compatible per channel scaling of the location loss weighting.
Example config:
Issue Number
Closes #2292
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60