Skip to content

[2298] Fix CI#2299

Open
tjhunter wants to merge 39 commits into
developfrom
tjh/dev/2298-ci
Open

[2298] Fix CI#2299
tjhunter wants to merge 39 commits into
developfrom
tjh/dev/2298-ci

Conversation

@tjhunter
Copy link
Copy Markdown
Collaborator

@tjhunter tjhunter commented May 4, 2026

Description

This PR should fix the CI issue. It makes several changes:

  • update uv requirements (get fixes for resolution and workspace)
  • introduce a sync-safe command that creates a venv in a more robust way. that should make sure that SCRATCH cache is touched and refreshed enough that it does not get cleaned
  • fixes a number of issues when creating a new venv. these issues were hidden because of caching, they are now exposed every time by the CI.

Issue Number

Closes #2298

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@github-actions github-actions Bot added the infra Issues related to infrastructure label May 4, 2026
Copy link
Copy Markdown
Contributor

@grassesi grassesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the modified commands (sync-safe, lint) on Juptir: works fine. Note for people on Jupiter or juwels-booster who are using the uv package supplied by the module stack need to switch to standalone uv installation since the module stack only contains uv 0.7.4/0.8.17 . Alternatively we need to update the module stack.

Comment thread pyproject.toml Outdated
Copy link
Copy Markdown
Contributor

@sophie-xhonneux sophie-xhonneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, let's wait until after June 10th when we present results.

@github-project-automation github-project-automation Bot moved this to In Progress in WeatherGen-dev May 29, 2026
@clessig
Copy link
Copy Markdown
Collaborator

clessig commented May 29, 2026

This is a breaking change, let's wait until after June 10th when we present results.

What will be broken by this change?

@sophie-xhonneux
Copy link
Copy Markdown
Contributor

From my understanding, it will force everyone to change their uv installation or be blocked and with insufficiently tested consequences. It is simply not worth doing this before June 10th

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Issues related to infrastructure

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Integration tests are currently failing

4 participants