implement power spectra#2398
Open
iluise wants to merge 12 commits into
Open
Conversation
github-actions
Bot
added
the
eval
clessig
reviewed
May 27, 2026
| - psd: | ||
| psd_method: "sht" # "sht" (SHT-based) or "fft" (regrid FFT) | ||
| psd_regrid_resolution: 1.0 # degrees, only for fft method | ||
| grid_type: "octahedral" # "octahedral" (default), "regular", "reduced". |
Collaborator
There was a problem hiding this comment.
Should this be determined from the dataset?
| if psd_datasets is None: | ||
| continue | ||
|
|
||
| method_tag = psd_datasets[0].get("psd_method", "sht") |
Collaborator
There was a problem hiding this comment.
sht is only applicable for global, for the local ones we need to regard
| https://github.com/ecmwf/anemoi-core/blob/main/models/src/anemoi/models/layers/spectral_helpers.py | ||
|
|
||
| - **Path B – FFT PSD** (``method="fft"``): | ||
| 1-D zonal FFT along the longitude dimension on a regular lat-lon grid. |
Collaborator
There was a problem hiding this comment.
What about the necessary regrinding?
|
|
||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # FFT PSD (absorbed from psd_calc.py) |
Collaborator
There was a problem hiding this comment.
Remove the "absorbed ..."
|
|
||
| data_3d = np.empty((n_samples, nlat, nlon)) | ||
| for s in range(n_samples): | ||
| data_3d[s] = griddata(points, data[s], (grid_lat, grid_lon), method="nearest") |
Collaborator
There was a problem hiding this comment.
I think this needs to be documented somewhere. Does this work robustly for spherical grids, e.g. for the CERRA Lambertian projection one?
| @@ -0,0 +1,212 @@ | |||
| # (C) Copyright 2025 Anemoi contributors. | |||
Collaborator
There was a problem hiding this comment.
We should not merge this. We don't run it regularly and it's therefore not useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
code from
anemoi.models(https://github.com/ecmwf/anemoi-core/blob/main/models/src/anemoi/models/layers/)SphericalHarmonicTransformInverseSphericalHarmonicTransform(mostly for sanity check)evaluate/example_extras/power_spectra)Use it as:
NB. for N320 grids we need to use
reducedinstead ofoctahedral. I tested it for both O96 and N320 grids.The plots are in
<summary_dir>/psd. The code produces one plot per forecast step.I know it would be more appropriate to have them under
results/run_id/plots/psd, but I followed the same workflow of theqq_analysismetric and I will change this in another PR that restructures this part.Sanity check:
I implemented the same sanity check as what done in anemoi.models, so check that applying the
SphericalTransformand itsInverseSphericalTransformstarting from random noise gives the identity.Issue Number
Closes #2176
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60