Skip to content

Conversation

@pgeier
Copy link
Contributor

@pgeier pgeier commented Jan 9, 2026

Description

The metkit/codes/DataContent and UserDataContent is removed because it does not relate to eccodes.
It is used in mars-client-cpp and multio. For mars-client-cpp an replacement is provided through https://github.com/ecmwf/mars-client-cpp/pull/60.
For multio a replacement is already in place, although the general usage of eckit::message::Message is revisited.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@pgeier pgeier requested review from Ozaq and danovaro January 9, 2026 11:12
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.07%. Comparing base (931b2ae) to head (d5ee674).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #145      +/-   ##
===========================================
+ Coverage    70.83%   71.07%   +0.24%     
===========================================
  Files          132      130       -2     
  Lines         8188     8160      -28     
  Branches       784      781       -3     
===========================================
  Hits          5800     5800              
+ Misses        2388     2360      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pgeier pgeier marked this pull request as draft January 9, 2026 12:40
@pgeier pgeier marked this pull request as ready for review January 13, 2026 08:54
Copy link
Member

@danovaro danovaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danovaro danovaro merged commit 9422c12 into develop Jan 13, 2026
188 checks passed
@danovaro danovaro deleted the feature/remove-codes-datacontent branch January 13, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants