Skip to content

Feat/sub hourly mixed steps#514

Open
mathleur wants to merge 2 commits into
dynamic_grid_servicefrom
feat/sub_hourly_mixed_steps
Open

Feat/sub hourly mixed steps#514
mathleur wants to merge 2 commits into
dynamic_grid_servicefrom
feat/sub_hourly_mixed_steps

Conversation

@mathleur
Copy link
Copy Markdown
Member

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@peshence peshence mentioned this pull request May 6, 2026
@peshence peshence force-pushed the feat/sub_hourly_mixed_steps branch 2 times, most recently from e905128 to 0866b37 Compare May 8, 2026 22:11
@peshence peshence requested a review from Copilot May 12, 2026 10:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to target support for “mixed” step coordinate values (e.g., sub-hourly steps alongside step-range strings) while also removing the previously experimental “dynamic grid / switching grids” functionality and related optional dependency wiring.

Changes:

  • Updated sub-hourly step type-change logic and axis index-range selection to better tolerate mixed index types.
  • Removed dynamic grid replacement code and deleted the switching-grid helper module.
  • Tightened engine selection by erroring when an axis has no configured slicer; simplified some project tooling config.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pyproject.toml Removes cffi from test extras and drops the switching_grids optional-dependency group.
polytope_feature/polytope.py Raises a clearer error when an axis is missing an engine mapping.
polytope_feature/options.py Removes dynamic_grid option and the runtime grid-replacement logic.
polytope_feature/datacube/transformations/datacube_type_change/datacube_type_change.py Adjusts sub-hourly step parsing/sorting and de-duplicates output formatting.
polytope_feature/datacube/switching_grid_helper.py Deletes the switching-grid helper implementation.
polytope_feature/datacube/datacube_axis.py Reworks find_standard_indices_between to handle mixed-type index lists.
.pre-commit-config.yaml Removes pinned default Python version entry and normalizes hook indentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread polytope_feature/datacube/datacube_axis.py
Comment thread polytope_feature/datacube/datacube_axis.py Outdated
peshence added 2 commits May 12, 2026 16:28
Centralise timestep parsing into parse_step_timedelta(), handle string
ranges (e.g. "0-15") as opaque labels through the slicer and tree sorting.
@mathleur mathleur changed the base branch from develop to dynamic_grid_service May 28, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants