Feat/sub hourly mixed steps#514
Open
mathleur wants to merge 2 commits into
Open
Conversation
Closed
e905128 to
0866b37
Compare
There was a problem hiding this comment.
Pull request overview
This PR appears to target support for “mixed” step coordinate values (e.g., sub-hourly steps alongside step-range strings) while also removing the previously experimental “dynamic grid / switching grids” functionality and related optional dependency wiring.
Changes:
- Updated sub-hourly step type-change logic and axis index-range selection to better tolerate mixed index types.
- Removed dynamic grid replacement code and deleted the switching-grid helper module.
- Tightened engine selection by erroring when an axis has no configured slicer; simplified some project tooling config.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Removes cffi from test extras and drops the switching_grids optional-dependency group. |
polytope_feature/polytope.py |
Raises a clearer error when an axis is missing an engine mapping. |
polytope_feature/options.py |
Removes dynamic_grid option and the runtime grid-replacement logic. |
polytope_feature/datacube/transformations/datacube_type_change/datacube_type_change.py |
Adjusts sub-hourly step parsing/sorting and de-duplicates output formatting. |
polytope_feature/datacube/switching_grid_helper.py |
Deletes the switching-grid helper implementation. |
polytope_feature/datacube/datacube_axis.py |
Reworks find_standard_indices_between to handle mixed-type index lists. |
.pre-commit-config.yaml |
Removes pinned default Python version entry and normalizes hook indentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Centralise timestep parsing into parse_step_timedelta(), handle string ranges (e.g. "0-15") as opaque labels through the slicer and tree sorting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following: