fix(cli): fallback to latest undone session in undo show when all sessions are undone - #9
Open
Reyatsu99 wants to merge 1 commit into
Open
fix(cli): fallback to latest undone session in undo show when all sessions are undone#9Reyatsu99 wants to merge 1 commit into
Reyatsu99 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
undo showis called without arguments and all recorded sessions have been undone,session.Latest()returnsos.ErrNotExist. Previously,cmdShowwould output an opaque error (undo: no such session), even though sessions clearly exist inundo list.This PR updates
cmdShowto fall back to the most recent undone session with entries when no active sessions remain, outputting a contextual notice tostderr:(all sessions have been undone; showing the most recent)Changes
cmd/undo/main.gointogetShowSession(args []string)to enable clean unit testing without callingfatal()/os.Exit().session.Latest()returnsos.ErrNotExistand no explicit session ID was passed.cmd/undo/show_test.gocovering empty stores, 0-entry sessions, explicit ID lookups, mixed session states, and full output formatting.Verification
make test: All Go unit tests and 25 E2E integration test cases pass cleanly.