Skip to content

fix: remove course certificate filter from user program data retrieval #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Waleed-Mujahid merged 1 commit into from
Jan 1, 2026
Merged

fix: remove course certificate filter from user program data retrieval #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions credentials/apps/credentials/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def filter_visible(qs: "QuerySet") -> "QuerySet":
Filters a UserCredentials queryset by excluding credentials that aren't
supposed to be visible yet.
"""
# EDLYCUSTOM: we do not save course cert in credentials service, so removing this filter for now
visible_course_certs = _filter_visible_course_certificates(qs)
Copy link
Copy Markdown
Member Author

@Waleed-Mujahid Waleed-Mujahid Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter was removed in a previous PR. This comment is added in this PR to link both changes

visible_program_certs = _filter_visible_program_certificates(qs.filter(program_credentials__isnull=False))
visible_certs = visible_course_certs | visible_program_certs
Expand Down
3 changes: 2 additions & 1 deletion credentials/apps/records/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ def get_user_program_data(
allowed_statuses.append(ProgramStatus.RETIRED.value)

# Get a list of programs
programs = get_filtered_programs(request_site, allowed_statuses, **course_filters)
# EDLYCUSTOM: we do not save course cert in credentials service, so removing this filter for now
programs = get_filtered_programs(request_site, allowed_statuses)

# Get the completed programs and a UUID set using the program_credentials
program_credential_ids = [program_credential.credential_id for program_credential in program_credentials]
Expand Down
Loading