fix(frontend): tighten logo sizing on register page and header#323
Merged
Conversation
Matches the recent login/home logo adjustments — shrinks the register auth-card logo (72→56, mb-1→mb-6) and the nav header logo (80→56) so the header logo no longer overflows the h-16 navbar.
|
Claude finished @hamza-56's task in 1m 4s —— View job Review:
|
| File | Change | Verdict |
|---|---|---|
frontend/app/register/RegisterForm.tsx |
size={72} → size={56}, mb-1 → mb-6 |
✅ Now matches /login exactly |
frontend/components/SparkthHeader.tsx |
size={80} → size={56} |
✅ Fits within the h-16 (64px) navbar |
Consistency Check
The login page (frontend/app/login/LoginForm.tsx:76-77) uses size={56} with mb-6 — this PR now mirrors that exactly on /register. The SparkthLogo default prop is size={80} (SparkthLogo.tsx:8), and the header was previously using that default via an explicit size={80}. Reducing to 56 is appropriate since the rendered icon height is size * 0.72 ≈ 40px, which comfortably fits within the 64px (h-16) navbar with room for vertical centering.
Assessment
No issues found. This is a clean, minimal fix:
- No logic changes, no new dependencies, no React anti-patterns
- No security implications
- Sizing values are consistent across login/register pages
- Header logo now properly fits its container
Looks good to merge. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
72→56,mb-1→mb-6)SparkthHeadernav logo (80→56) so it fits within theh-16navbarTest plan
/register— logo sized consistently with/login/(landing) — header logo no longer overflows the nav bar