Skip to content

aarch64: fix malloc header on FreeBSD - #8

Open
valpackett wants to merge 1 commit into
edsiper:masterfrom
valpackett:patch-1
Open

aarch64: fix malloc header on FreeBSD#8
valpackett wants to merge 1 commit into
edsiper:masterfrom
valpackett:patch-1

Conversation

@valpackett

Copy link
Copy Markdown

It's actually weird that there's a check for HAVE_POSIX_MEMALIGN but it's not set by CMake… anyway, this is the minimal change to fix compilation

@valpackett

Copy link
Copy Markdown
Author

also the upstream library has a different implementation https://github.com/byuu/higan/blob/master/libco/aarch64.c

@girgen

girgen commented Feb 15, 2021

Copy link
Copy Markdown
Contributor

This should be merged, IMO.

@edsiper

edsiper commented Feb 24, 2021

Copy link
Copy Markdown
Owner

FYI: we are upgrading to the latest libco, and looks like we might be good with the original upstream version... still testing.

can you help testing https://github.com/higan-emu/libco ?

@areese

areese commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

@edsiper @girgen
monkey/monkey#340

That pr checks for POSIX_MEMALIGN using CMake as FreeBSD isn't the only thing that will break.

@valpackett

Copy link
Copy Markdown
Author

+1 to that cmake check, but please add the malloc_np.h header there

@areese

areese commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

@unrelentingtech I see, I'll put that in.

@areese

areese commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

@unrelentingtech fixed in monkey/monkey#340

@areese

areese commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

This is duplicated by #10 which also supports Apple Silicon

@areese

areese commented Dec 18, 2021

Copy link
Copy Markdown
Contributor

We can close this if it’s duplicated with 10
I think I broke this out as a separate patch

@areese

areese commented Dec 18, 2021

Copy link
Copy Markdown
Contributor

Yes this was fixed when I did the Apple silicon patch please retest thank you

@girgen

girgen commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

This seems to be fixed in the 1.9.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants