test: add TestPathRedirectionMiddleware integration tests AP-1547
#298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
2 times, most recently
from
14220fc to
10dd64f
Compare
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
9 times, most recently
from
86c3ec7 to
5816b47
Compare
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
2 times, most recently
from
1564138 to
7724856
Compare
Contributor
mariajgrimaldi
left a comment
mariajgrimaldi
left a comment
There was a problem hiding this comment.
I'm not sure if this PR is ready for review, cause I think an issue was still being addressed. Please, let me know to go through it again :)
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
from
cf996d8 to
80ed570
Compare
mariajgrimaldi
previously approved these changes
Nov 13, 2024
Contributor
mariajgrimaldi
left a comment
mariajgrimaldi
left a comment
There was a problem hiding this comment.
I left a few non-blocking comments for you to address. Other than that, it looks good to me!
Contributor
|
@BryanttV, thanks for the context! |
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
from
567f831 to
2979348
Compare
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
from
6f5e30b to
731cfd8
Compare
mariajgrimaldi
previously approved these changes
Nov 18, 2024
magajh
reviewed
Nov 18, 2024
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
from
731cfd8 to
4e9311a
Compare
magajh
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for the
TestPathRedirectionMiddlewaremiddleware. These tests are executed in the job of Tutor Integration TestsTesting instructions
Check the jobs of Tutor Integration Tests in the PR.
Jira Issue