Skip to content

fix: prevent 'null' display when instructor family_name is missing#9

Open
rjv31 wants to merge 1 commit into
masterfrom
handle-missing-family-name-in-instructor-profile
Open

fix: prevent 'null' display when instructor family_name is missing#9
rjv31 wants to merge 1 commit into
masterfrom
handle-missing-family-name-in-instructor-profile

Conversation

@rjv31
Copy link
Copy Markdown

@rjv31 rjv31 commented May 12, 2026

Issue
Instructor profiles display "null" when family_name is missing.

2U Ticket
https://2u-internal.atlassian.net/browse/CATALOG-87

Root Cause
The marketing site integration was using full_name directly, which could include null values.

Fix
Updated name construction in MarketingSitePeople to safely handle missing family_name
Ensured only valid name parts are included
Added test coverage for missing and empty family_name cases
Testing
Verified profiles with and without family_name
Confirmed no "null" appears in marketing site payload

@rjv31 rjv31 requested a review from ankit-sonata May 12, 2026 18:39
@rjv31 rjv31 marked this pull request as ready for review May 13, 2026 18:16
@ankit-sonata
Copy link
Copy Markdown

@rjv31 Looks good overall — focused fix and tests cover the missing/empty family_name cases well. Non-blocking thought: it may be worth adding a test for the case where both given_name and family_name are empty and only salutation exists, just to lock down expected behavior.

@rjv31 rjv31 force-pushed the handle-missing-family-name-in-instructor-profile branch from a5fbb6b to 96b7709 Compare May 14, 2026 13:02
@rjv31
Copy link
Copy Markdown
Author

rjv31 commented May 14, 2026

Hi @ankit-sonata Thanks for the suggestion. I’ve updated the implementation and added coverage for the additional edge-case scenarios to align with the expected behavior when family_name is missing or empty while preserving salutation handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants