fix: prevent 'null' display when instructor family_name is missing#9
Open
rjv31 wants to merge 1 commit into
Open
fix: prevent 'null' display when instructor family_name is missing#9rjv31 wants to merge 1 commit into
rjv31 wants to merge 1 commit into
Conversation
|
@rjv31 Looks good overall — focused fix and tests cover the missing/empty family_name cases well. Non-blocking thought: it may be worth adding a test for the case where both given_name and family_name are empty and only salutation exists, just to lock down expected behavior. |
a5fbb6b to
96b7709
Compare
Author
|
Hi @ankit-sonata Thanks for the suggestion. I’ve updated the implementation and added coverage for the additional edge-case scenarios to align with the expected behavior when family_name is missing or empty while preserving salutation handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Instructor profiles display "null" when family_name is missing.
2U Ticket
https://2u-internal.atlassian.net/browse/CATALOG-87
Root Cause
The marketing site integration was using full_name directly, which could include null values.
Fix
Updated name construction in MarketingSitePeople to safely handle missing family_name
Ensured only valid name parts are included
Added test coverage for missing and empty family_name cases
Testing
Verified profiles with and without family_name
Confirmed no "null" appears in marketing site payload