Revert "chore: Upgrade Python requirements"#1198
Conversation
This reverts commit 4ba904a.
ttak-apphelix
deleted the
revert-1196-repo-tools/upgrade-python-requirements-547f4ff
branch
There was a problem hiding this comment.
Pull request overview
Reverts a prior “upgrade Python requirements” change set by downgrading the supported Python version/pins back to 3.11-era lockfiles and adjusting CI/tox configuration accordingly.
Changes:
- Switch tox default envlist from Python 3.12 to 3.11.
- Revert
python_requiresand multiple compiledrequirements/*.txtpins to versions generated with Python 3.11. - Update CI workflow’s Python matrix (now includes both 3.11 and 3.12).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Changes default tox envlist to Python 3.11. |
| setup.py | Updates declared python_requires and Trove classifiers. |
| requirements/base.txt | Reverts compiled runtime dependency pins (generated under Python 3.11). |
| requirements/test.txt | Reverts compiled test dependency pins (generated under Python 3.11). |
| requirements/scripts.txt | Reverts compiled script dependency pins (generated under Python 3.11). |
| requirements/quality.txt | Reverts compiled quality/tooling dependency pins (generated under Python 3.11). |
| requirements/dev.txt | Reverts compiled dev dependency pins (generated under Python 3.11). |
| requirements/ci.txt | Reverts compiled CI tooling pins (generated under Python 3.11). |
| requirements/doc.txt | Reverts compiled doc dependency pins (generated under Python 3.11). |
| requirements/pip.txt | Reverts pip/wheel toolchain pins (generated under Python 3.11). |
| requirements/pip-tools.txt | Reverts pip-tools/build toolchain pins (generated under Python 3.11). |
| .github/workflows/ci.yml | Expands CI to test both Python 3.11 and 3.12. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| classifiers=[ | ||
| 'Development Status :: 3 - Alpha', | ||
| 'Framework :: Django', | ||
| 'Framework :: Django :: 4.2', | ||
| 'Framework :: Django :: 2.2', | ||
| 'Intended Audience :: Developers', | ||
| 'License :: OSI Approved :: GNU Affero General Public License v3 or later (AGPLv3+)', | ||
| 'Natural Language :: English', | ||
| 'Programming Language :: Python :: 3', | ||
| 'Programming Language :: Python :: 3.12', | ||
| 'Programming Language :: Python :: 3.11', |
There was a problem hiding this comment.
The Trove classifier was reverted to Framework :: Django :: 2.2, but this repo’s pinned runtime/test dependencies are on Django 5.2.x (see requirements/base.txt) and tox also references a django42 factor. This package metadata will be inaccurate for consumers; update the classifier(s) to match the supported Django major/minor versions (or adjust requirements/tox if the intended support is actually 2.2).
| [tox] | ||
| envlist = py{312}-django{42}, quality | ||
| envlist = py{311}-django{42}, quality |
There was a problem hiding this comment.
envlist defines only py311-django42, but CI sets TOXENV=django42 (no matching testenv) and the django42 factor pulls in Django>=4.2,<4.3 while requirements/test.txt brings in requirements/base.txt which pins Django 5.2.x. As-is, tox will either fail to find the env or fail dependency resolution. Align the tox env naming with CI (e.g., add an explicit [testenv:django42] that uses the active interpreter), and ensure the Django version constraints are consistent with the compiled requirements used by that env.
| strategy: | ||
| matrix: | ||
| python-version: ['3.12'] | ||
| python-version: ['3.11', '3.12'] |
There was a problem hiding this comment.
The workflow matrix now runs Python 3.12, but tox.ini’s envlist only defines py311-... and the job sets TOXENV=django42, which is not a defined tox environment. This combination is likely to break CI. Either remove 3.12 from the matrix, or add matching tox environments (e.g., py312-... or a django42 env that uses the active Python) and update matrix.tox-env accordingly.
| python-version: ['3.11', '3.12'] | |
| python-version: ['3.11'] |
Reverts #1196