Skip to content

feat: Add batch size parameter to retire_certs_s3 for incremental processing#1203

Merged
Akanshu-2u merged 2 commits into
mainfrom
ttak-apphelix/BOMS-488-batching
May 14, 2026
Merged

feat: Add batch size parameter to retire_certs_s3 for incremental processing#1203
Akanshu-2u merged 2 commits into
mainfrom
ttak-apphelix/BOMS-488-batching

Conversation

@ttak-apphelix
Copy link
Copy Markdown
Member

@ttak-apphelix ttak-apphelix commented May 14, 2026

Overview:

Adds an optional batch_size query parameter to the certificate S3 retirement endpoint so scheduled jobs can process certificates incrementally instead of draining the full queue in one call.

Changes:

  • Parses batch_size from RetireCertificatesS3View query params and applies it as a queryset limit.
  • Logs the effective batch size when retirement starts.
  • Bumps package version to 7.5.0 and adds a changelog entry

Private JIRA ticket:

Related PR(private):

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Fixup commits are squashed away

Copilot AI review requested due to automatic review settings May 14, 2026 06:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an optional batch_size query parameter to the certificate S3 retirement endpoint so scheduled jobs can process certificates incrementally instead of draining the full queue in one call.

Changes:

  • Parses batch_size from RetireCertificatesS3View query params and applies it as a queryset limit.
  • Logs the effective batch size when retirement starts.
  • Bumps package version to 7.5.0 and adds a changelog entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
edx_arch_experiments/certificates/views.py Adds batch-size handling to the certificate retirement endpoint.
edx_arch_experiments/__init__.py Updates package version to 7.5.0.
CHANGELOG.rst Documents the new batch_size query parameter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread edx_arch_experiments/certificates/views.py Outdated
Comment thread edx_arch_experiments/certificates/views.py
@Akanshu-2u Akanshu-2u merged commit 5abcbc8 into main May 14, 2026
6 checks passed
@Akanshu-2u Akanshu-2u deleted the ttak-apphelix/BOMS-488-batching branch May 14, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants