feat: surface audit expiration date

[GBalaji3320]

Audit expiration date https://2u-internal.atlassian.net/browse/SUBS-102

Adding the LMS enrollment endpoint, which will therefore proxy through the partner API enrollment endpoint.

[Copilot]

Pull request overview

Adds new enrollment response fields to expose whether an enrollment is audit and (for audit enrollments) the access expiration date derived from the course’s verified-mode upgrade deadline.

Changes:

• Extend CourseEnrollmentSerializer/CourseEnrollmentsApiListSerializer with isAudit and accessExpirationDate.
• Add/adjust tests asserting the new response fields for the single-enrollment endpoint.
• Update API list fixture expectations to include the new fields.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
openedx/core/djangoapps/enrollments/serializers.py	Adds isAudit / accessExpirationDate serializer fields and computation logic.
openedx/core/djangoapps/enrollments/tests/test_views.py	Updates enrollment endpoint tests to assert new fields.
openedx/core/djangoapps/enrollments/tests/fixtures/course-enrollments-api-list-valid-data.json	Updates expected API list results to include new fields.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ankit-sonata]

@GBalaji3320,

1. isAudit doesn't just mean "is enrollment in audit mode" — it means "is audit mode AND verified mode has an expiration." The name is misleading. Something like is_audit_with_expiring_upgrade would be clearer. A consumer seeing mode == 'audit' but isAudit == False would be confused.

2. The existing test_check_enrollment adds assertions for the default (honor) mode which is good. But there's no dedicated test for an audit enrollment without a verified mode expiration (should return isAudit: false, accessExpirationDate: null).

3. Both get_accessExpirationDate and get_isAudit perform a separate DB query (CourseMode.objects.filter(...)) per enrollment object. On list endpoints returning many enrollments, this creates an N+1 query problem (actually 2N extra queries). Use select_related/prefetch

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[GBalaji3320]

@GBalaji3320,

1. isAudit doesn't just mean "is enrollment in audit mode" — it means "is audit mode AND verified mode has an expiration." The name is misleading. Something like is_audit_with_expiring_upgrade would be clearer. A consumer seeing mode == 'audit' but isAudit == False would be confused.
2. The existing test_check_enrollment adds assertions for the default (honor) mode which is good. But there's no dedicated test for an audit enrollment without a verified mode expiration (should return isAudit: false, accessExpirationDate: null).
3. Both get_accessExpirationDate and get_isAudit perform a separate DB query (CourseMode.objects.filter(...)) per enrollment object. On list endpoints returning many enrollments, this creates an N+1 query problem (actually 2N extra queries). Use select_related/prefetch

@ankit-sonata
Based upon your the above comments I have made accordingly.