Feature/ses enrollment email templates#294
Draft
nthriveni-sonata-ship-it wants to merge 3 commits into
Draft
Conversation
jsnwesson
reviewed
May 18, 2026
| Build absolute URLs for enrollment email images. | ||
|
|
||
| This function constructs full image URLs for SES email delivery. When Braze renders | ||
| the email through SES, it needs absolute URLs because email clients cannot resolve |
Member
There was a problem hiding this comment.
I'm sort of confused by the explanation here, since Braze shouldn't be involved in triggering an email to SES. Can you clarify what you mean by "When Braze renders the email through SES"?
Member
Author
There was a problem hiding this comment.
the wording there is incorrect.
What I intended to convey is that email clients require fully qualified image URLs since relative/static asset paths are not resolvable outside the LMS environment.
I’ll update the comment to make that clearer and remove the Braze reference.
abf07ab to
d96e195
Compare
…(no behavior change)
d96e195 to
f571e8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Course enrollment emails are currently sent via Braze Canvas, where:
canvas_entry_propertiesWhat This PR Contains
This PR introduces draft Django email templates for course enrollment:
tasks.pyto support future SES renderingThese templates are designed to replicate the current Braze email design and behavior.
Important — Review-Only PR
This PR is not intended to be merged.
It is shared strictly for:
There are no functional changes and no impact on the current email flow.
Braze remains the only active rendering mechanism.
Backend Notes (Scope Clarification)
tasks.pyincludes preparatory changes only:tasks.pyis not part of the review scope for this PR.Why Templates Are in
edx-platform(and notedx-themes)These templates are intentionally added to
edx-platformfor this review.Reason
They are:
Adding them to
edx-themesat this stage would:Intentional Placement
Placing them in
edx-platform:What Comes Next
After review and alignment:
Once templates are part of the active rendering flow, theming considerations (including
edx-themes) can be revisited.Testing
Templates have been validated locally for:
No runtime behavior changes are introduced.
Summary
This PR serves as a design and structure review checkpoint:
edx-platformas non-active, review-only artifacts