[DO NOT MERGE]feat: add instrumentation to forum#20
Open
jcapphelix wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds instrumentation around forum repo.
The need for this comes from us switching from v1 to v2 (Code wise, not backend wise), and the need for that comes from us bringing
ulmo.1changes.Older implementation of forum
cs_comments_servicehad it's own place in datadog, but that is no longer the case with edx/forum.Thus this PR works in that direction, we won't have exactly same level of observability as we had
cs_comments_servicebut this makes it more or less similar.NOTE :- One need not merge this to check on staging, it can stay as is in a branch to check if it works or not in staging, the PR on how to add it in staging is available in "Related PR" section below.
DO NOT MERGE this in
release-ulmowithout testing and making required changes.THIS IS POC only.
Useful links
Related PR
https://github.com/edx/edx-internal/pull/14147