Skip to content
This repository was archived by the owner on Jan 21, 2021. It is now read-only.

upgrade gunicorn and django #40

Open
Ali-D-Akbar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

upgrade gunicorn and django #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83b8b2b
upgrade gunicorn and django
Ali-D-Akbar Jan 6, 2021
af4cf07
upgrade gunicorn and django
Ali-D-Akbar Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements/base.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Django >= 1.4, < 1.5
Django
Copy link

@stvstnfrd stvstnfrd Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a constraint or max version specified to prevent us from installing a major version bump?

Copy link
Author

@Ali-D-Akbar Ali-D-Akbar Jan 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw one PR that seems to be a safe upgrade for django to me.
#39

I'm still not 100% sure about this as I have no idea about this repository.

Copy link

@UsamaSadiq UsamaSadiq Jan 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When removing the version constraint from base.in, you should instead pin the version in the constraints.txt file. This is the method that we use in most of the edX repos. Not adding the upper constraint on Django version will update it to the latest version whenever django-nose constraint is updated.

pika
django_nose==1.4.1
nosexcover
Expand All @@ -12,4 +12,4 @@ anyjson==0.3.3
numpy==1.6.2
lxml==2.3.6
newrelic==2.46.0.37
gunicorn==0.17.4
gunicorn
39 changes: 20 additions & 19 deletions requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,30 @@
#
# make upgrade
#
anyjson==0.3.3
boto==2.6.0
certifi==2019.11.28 # via requests
anyjson==0.3.3 # via -r requirements/base.in
boto==2.6.0 # via -r requirements/base.in
certifi==2020.12.5 # via requests
chardet==3.0.4 # via requests
colorama==0.4.3 # via rednose
coverage==5.0.2 # via nosexcover
django==1.4.22
django_nose==1.4.1
dogstatsd-python==0.2.1
gunicorn==0.17.4
colorama==0.4.4 # via rednose
coverage==5.3.1 # via nosexcover
django==1.11.29 # via -r requirements/base.in, django-nose
django_nose==1.4.1 # via -r requirements/base.in
dogstatsd-python==0.2.1 # via -r requirements/base.in
gunicorn==19.10.0 # via -r requirements/base.in
idna==2.8 # via requests
lxml==2.3.6
newrelic==2.46.0.37
lxml==2.3.6 # via -r requirements/base.in
newrelic==2.46.0.37 # via -r requirements/base.in
nose==1.3.7 # via django-nose, nosexcover
nosexcover==1.0.11
numpy==1.6.2
path.py==10.0
pika==1.1.0
rednose==1.3.0
requests==2.22.0
south==1.0.2
nosexcover==1.0.11 # via -r requirements/base.in
numpy==1.6.2 # via -r requirements/base.in
path.py==10.0 # via -r requirements/base.in
pika==1.1.0 # via -r requirements/base.in
pytz==2020.5 # via django
rednose==1.3.0 # via -r requirements/base.in
requests==2.22.0 # via -r requirements/base.in
south==1.0.2 # via -r requirements/base.in
termstyle==0.1.11 # via rednose
urllib3==1.25.7 # via requests
urllib3==1.25.11 # via requests

# The following packages are considered to be unsafe in a requirements file:
# setuptools