fix(mandatory-scope-binding): flag potential invocations only#183
Merged
Conversation
✅ Deploy Preview for eslint-plugin ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
mandatory-scope-bindingover-flagged everyEventCallble&Effectreference (specifically,Identifier) it found in a component without regard to its usage – it even erroneously flagged function arguments. But the essence of the rule has always been to preventScopeless calls, so this PR significantly improves (narrows down) the search.Only direct or transitive (via an unknowing consumer) invocations actually risk bypassing
Scopebinding. So the rule now matches at four specific "boundary" positions + analyzes actual usage.There's now also a "delegation contract" exception. We now allow passing a
Unitto a callee within React jurisdiction whose declared argument type explicitly guarantees it's is aware the argument is aUnit. The rule assumes that the receiver is itself bound by the very same rule and "delegates" scope binding to that receiver.