Add support for custom flags based on environment#1031
Open
marvinborner wants to merge 2 commits intomainfrom
Open
Add support for custom flags based on environment#1031marvinborner wants to merge 2 commits intomainfrom
marvinborner wants to merge 2 commits intomainfrom
Conversation
marvinborner
commented
Jun 1, 2025
| os match { | ||
| case OS.POSIX => | ||
| val shebang = "#!/usr/bin/env node" | ||
| val shebang = s"#!/usr/bin/env -S node ${flags.mkString(" ")}" |
Member
Author
There was a problem hiding this comment.
Not sure how reliable env -S is for other platforms, but I do not see another elegant way of adding the flags to the node runner. See https://unix.stackexchange.com/questions/399690/multiple-arguments-in-shebang
Member
Author
Member
Author
|
No idea what's happening with CI, can not reproduce errors locally. CI also doesn't seem to have anything relevant in the environment. Hmmm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permits a temporary fix for #1026.
We can now do
NODE_FLAGS="--max-old-space-size=8192"and it will automatically add the flags to thenoderunner flags (in shebang). I also addedVALGRIND_FLAGS,CHEZ_FLAGS, andCFLAGS(for historic reasons)