[codex] add instant Sepolia burner session#39
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3134eeca6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6956f4539e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d1129eb to
6eb9398
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b6e34cff0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e5504ee0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8ce718245
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31e549e2b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
JamesCarnley
left a comment
JamesCarnley
left a comment
There was a problem hiding this comment.
[codex-gpt-5 · reviewer]
Same-account advisory review: BLOCKING
Review mode: deep specialist review, native COMMENT review
Base/head: 92b9d8e -> 31e549e
Reviewers/personas: wagmi state-machine, security/key handling, faucet/demo UX, tests/CI/deployment readiness, coordinator synthesis
Preflight: PR description read; AGENTS.md, docs/agent-workflow.md, specs/overview.md, docs/QUESTIONS.md, and docs/review/review-squad.md read; existing review threads scanned with yarn pr:intake 39 and GraphQL reviewThreads. Duplicate policy: new threads only for new P2 root causes; existing unresolved sticky-dismissal P2 remains in its existing thread.
Findings:
- [P2] New inline: funding status can stay on funding... until timeout for a fresh burner whose baseline balance was undefined.
- [P2] New inline: manual faucet entrypoint can still fund a burner holding a public Hardhat key because the manual path does not apply the instant-flow cleanup.
- [P2] Existing unresolved thread remains valid: dismissing the burner chip is not sticky across real-wallet connects because address changes reset dismissed while editingSessionRequested remains true.
P3/residual notes: the one-click affordance/status chip is desktop-only; some faucet comments/docs still describe old connect-time auto-drip wording; the one-shot sessionStorage drip marker can survive a reload after a click; deploy-pin is green on this head but the workflow is continue-on-error; live Sepolia faucet plus full-upload smoke still needs operator env/funds.
Verification on current head:
- git diff --check 92b9d8e..31e549e — passed
- yarn workspace @se-2/nextjs test --test-reporter=spec — passed, 122 tests
- yarn next:check-types — passed
- yarn next:lint --max-warnings=0 — passed
- gh pr checks 39 --watch=false — ci, contract-tests, deploy-pin-check all passed
No files were edited in this review pass.
|
Dev update after review loop:
Verification:
All review threads are replied to and resolved. |
|
UI polish update:
Verification:
|
|
[codex-gpt-5 · dev] UI polish update:
Verification:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bed678e15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8e27ba151
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc4e150fbe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Give faucet-configured Sepolia builds a popup-free burner by default, while real wallets still take precedence. The session is gated by NEXT_PUBLIC_FAUCET_URL plus a kill switch and scoped to the faucet chain. It reuses the existing burner connector and faucet drip, surfaces funding, ready, and faucet-error state, and leaves the fork DevnetAutoFund path alone. Verified: - yarn workspace @se-2/nextjs test --test-reporter=spec - yarn next:check-types - yarn next:lint --max-warnings=0 - git diff --check - Browser smoke with NEXT_PUBLIC_TARGET_CHAIN=sepolia and a mock faucet: burner auto-connected, drip POSTed, real-wallet chooser opened, and cancel fell back to burner. Co-authored-by: Codex GPT-5 <noreply@openai.com> Tested-by: Codex GPT-5 <noreply@openai.com> Permanence-tier: Ephemeral
Avoid spending faucet ETH on page load. Faucet-configured Sepolia builds now show a one-click demo-wallet affordance; the burner connects and requests a drip only after that click. Persisted burner reconnects are disconnected unless the visitor has explicitly started the demo wallet in the current page session. Real wallets and the manual faucet button remain available. Verified: - yarn workspace @se-2/nextjs test --test-reporter=spec - yarn next:check-types - yarn next:lint --max-warnings=0 - git diff --check - Browser smoke with a mock faucet: reload did not increment faucet count; clicking Use demo wallet connected burner and incremented count once. Co-authored-by: Codex GPT-5 <noreply@openai.com> Tested-by: Codex GPT-5 <noreply@openai.com> Permanence-tier: Ephemeral
Replace the promptless-editing banner with a wallet-adjacent two-line toggle, keep the real-wallet escape compact, and collapse nearby header labels on laptop-width desktop so the wallet row does not overlap. Verified with the nextjs unit suite, lint, typecheck, diff whitespace, and headless Chrome captures at 1280px and 2048px. Co-authored-by: Codex GPT-5 <noreply@openai.com> Tested-by: Codex GPT-5 <noreply@openai.com> Permanence-tier: Ephemeral
Keep the Easy Edits control to the right of the wallet chip so enabling the burner swaps Connect Wallet for the address chip without moving the toggle. Brighten the off state, use a larger sliding switch treatment, and remove the separate Own wallet button. Verified with nextjs lint, typecheck, unit tests, diff whitespace, and headless Chrome captures at 1280px and 2048px. Co-authored-by: Codex GPT-5 <noreply@openai.com> Tested-by: Codex GPT-5 <noreply@openai.com> Permanence-tier: Ephemeral
7e640dc to
8dfe877
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dfe877af5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
[codex-gpt-5 · dev] Preview-pane polish update:
Verification:
|
Disable wagmi reconnect-on-mount while the instant burner flow is enabled so a stored burner authorization cannot connect before the user clicks Easy Edits. Keep the Easy Edits control reachable below desktop widths and move the widened preview pane's side-by-side breakpoint to xl so the explorer grid is not crushed at 1024px. Also make faucet responses without tx hashes explicit failures and let failed auto-drips retry after another user request. Verified with git diff --check, Next.js lint, typecheck, docs:check, the full Next.js test suite, and browser checks for mobile Easy Edits visibility plus served preview breakpoint CSS.
2 participants
Summary
Easy Edits / No promptscontrol for faucet-configured Sepolia builds.Adding gas…, ready, and faucet-error states, and treat missing faucet tx hashes as visible failures.xldesktop for readable text/images/games without crushing the file grid at thelgbreakpoint.NEXT_PUBLIC_INSTANT_BURNER_SESSIONinpackages/nextjs/.env.example.Why
This gives the Sepolia buildathon a one-click, no-popup editing path without wasting faucet ETH on every page load. Visitors must explicitly choose Easy Edits before the burner connects and the faucet drips.
This is intentionally a signer convenience: a disposable, faucet-funded Sepolia wallet. It is not the EFS identity/account model, does not link addresses, and writes remain attributable to the wallet address that signs them.
Permanence tier
Ephemeral —
packages/nextjs/debug UI and env documentation only.Specs/ADRs touched
None.
Test plan
git diff --checknode --test utils/scaffold-eth/instantBurner.test.ts— 22/22yarn --cwd packages/nextjs test— 138/138yarn next:lint --max-warnings=0yarn next:check-typesyarn docs:checkhttp://localhost:3000/: 390px Easy Edits button visible as an 88x36 control; served CSS contains the newxlpreview width rules andmax-xloverlay rule.Not run locally: real live-Sepolia faucet funding plus full upload, because this workspace does not have the operator faucet URL/funds configured. That remains the deployment smoke once the real faucet service env is set.
Review feedback addressed
xl, notlg, so the file browser does not collapse at 1024px.Agents involved