Conversation
Agent-Logs-Url: https://github.com/egohygiene/renderflow/sessions/2ad1a11f-c40f-44c1-9e3c-45fa29dcfed7 Co-authored-by: szmyty <14865041+szmyty@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor duplicated Pandoc argument construction into shared builder
⚙️ Extract shared PandocArgs builder for consistent pandoc command construction
Mar 26, 2026
szmyty
approved these changes
Mar 27, 2026
Pull Request Summary by devActivityMetricsAchievements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each output strategy (HTML, PDF, DOCX) was independently constructing pandoc argument lists — duplicating
--from, input path, and-oboilerplate with no shared abstraction.Changes
PandocArgsbuilder (src/strategies/pandoc_args.rs) — centralises all pandoc arg construction:new(input_format, input_path, output_path)— mandatory base argswith_template(path)→--template <path>(HTML, PDF)with_pdf_engine(engine)→--pdf-engine=<engine>(PDF)with_reference_doc(path)→--reference-doc <path>(DOCX)build() -> Vec<String>— emits the final arg listhtml.rs,pdf.rs,docx.rs) to use the builder via immutablematch-chaining rather thanmutreassignmentPandocArgsre-exported fromstrategies/mod.rsUsage
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.