fix: drop use of !reference in .benchmarks:{default,nightly} #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hashes are supposed to be merged recursively when we use `extends`.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant !reference directives from GitLab CI configuration. When using extends, GitLab CI automatically performs recursive merging of variables, making the explicit !reference calls unnecessary.
Key Changes
- Removed duplicate
!reference ['.benchmarks', variables]entries from benchmark job definitions - Simplified configuration while maintaining the same effective behavior through
extends
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Same as #84? |
Member
Author
But worse. Previous PR is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hashes are supposed to be merged recursively when we use
extends.