Skip to content

Replace deprecated operator-> with . on podio collection references#7

Closed
Copilot wants to merge 4 commits intomainfrom
copilot/fix-dereference-operator-in-juggler
Closed

Replace deprecated operator-> with . on podio collection references#7
Copilot wants to merge 4 commits intomainfrom
copilot/fix-dereference-operator-in-juggler

Conversation

Copy link

Copilot AI commented Nov 28, 2025

Podio removed the deprecated operator->() on collection objects in AIDASoft/podio#812. This PR updates juggler to use . instead of -> when accessing methods on collection references.

Changes

  • FarForwardParticles.cpp: rc->push_back()rc.push_back()
  • FarForwardParticlesOMD.cpp: rc->push_back()rc.push_back()

Context

The issue only affects collection references, not pointers:

// Reference pattern (FIXED) - was using deprecated operator->()
auto& rc = *(m_outputParticles.createAndPut());
rc.push_back(rpTrack);  // ✓ correct

// Pointer pattern (unchanged) - uses built-in pointer dereference
auto* ptr = m_outputCollection.createAndPut();
ptr->push_back(item);  // ✓ correct, not affected

Other files in the repository use the pointer pattern and require no changes.

Original prompt

This section details on the original issue you should resolve

<issue_title>Juggler uses dereference operator-> on podio collections</issue_title>
<issue_description>The current code in juggler uses operator-> on podio collections, which was removed in AIDASoft/podio#812. We should replace instances of -> with . on collections.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits November 28, 2025 21:48
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix dereference operator usage in juggler for podio collections Replace deprecated operator-> with . on podio collection references Nov 28, 2025
Copilot AI requested a review from wdconinc November 28, 2025 21:52
@wdconinc wdconinc marked this pull request as ready for review November 28, 2025 21:53
@wdconinc wdconinc closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Juggler uses dereference operator-> on podio collections

2 participants

Comments