fix: Markdown code block contrast in dark mode (fixes #1253)#1257
Open
spider-yamet wants to merge 4 commits intoeigent-ai:mainfrom
Open
fix: Markdown code block contrast in dark mode (fixes #1253)#1257spider-yamet wants to merge 4 commits intoeigent-ai:mainfrom
spider-yamet wants to merge 4 commits intoeigent-ai:mainfrom
Conversation
bytecii
approved these changes
Feb 13, 2026
Collaborator
bytecii
left a comment
There was a problem hiding this comment.
Can you also add a snapshot?
Contributor
|
thanks @spider-yamet for the contribution! Could you add a short video or snapshot for your PR like how #1258 did? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unreadable code blocks in dark mode (dark text on dark background) and ensures code blocks use theme-aware foreground color everywhere.
Fixes #1253
Changes
Dark mode code block contrast
src/style/markdown-styles.css: In[data-theme='dark'], set explicit text color for code:.markdown-body preand.markdown-body pre code:color: #e6edf3.markdown-body code(inline):color: #e6edf3github-markdown-cssonly usesprefers-color-scheme, so--fgColor-defaultstayed dark and code was unreadable on dark backgrounds.Theme token for code foreground
src/style/token.css: In[data-theme='dark'], set--code-foreground: #e6edf3so code text follows app theme and stays readable on--code-surface.WorkFlow MarkDown
src/components/WorkFlow/MarkDown.tsx: Appliedtext-code-foregroundtopreandcode(block and inline) so workflow markdown code blocks use the semantic token and stay readable in dark mode.Testing