fix(ui): prevent install screen flash when already on main content#1280
Open
dataCenter430 wants to merge 1 commit intoeigent-ai:mainfrom
Open
fix(ui): prevent install screen flash when already on main content#1280dataCenter430 wants to merge 1 commit intoeigent-ai:mainfrom
dataCenter430 wants to merge 1 commit intoeigent-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1260
Related Issue
Layout visibility race: setWaitingBackend() could briefly show the install
screen after main content had already rendered.
initState only; stop using installationState === 'waiting-backend'.
Description
so we never switch to the install UI if the user is already "done". Still run
backend polling in the background.
initState only; stop using installationState === 'waiting-backend' so that
a late waiting-backend state cannot override and show the install screen when
initState is already 'done'.
Expected behavior
Before: User sees main app (initState is "done"). An async path (e.g. initial “tools installed, wait for backend” or login-after-logout) calls setWaitingBackend(). Layout sees installationState === 'waiting-backend' and shows the install screen, causing a brief flash or full switch back to the install screen.
After: If the user is already "done", we never call setWaitingBackend() for that flow, and Layout no longer uses waiting-backend alone to show the install screen. So the install screen does not appear after main content has rendered. Backend polling still runs; when the backend is ready we stay on main content (or show an error dialog if it fails). During normal first-time setup (initState carousel/permissions), the install screen still shows and “waiting for backend” still appears as before.
Why it’s better
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement