Keep replay and history prompts tied to the right task#1622
Draft
09Catho wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two closely related prompt mixups in the project replay/history flow.
When replaying a finished task, the app could grab the first prompt it found anywhere in the project instead of the prompt that belonged to the task you actually replayed. Reopening a multi-task project from history had the same shape of bug: every restored task could inherit one shared question instead of its own original prompt.
What changed:
Closes #1367
Closes #1366
Tested with:
npx vitest run test/integration/chatStore/replayComplete.test.tsx -t "active task question|per-task questions|correct first question on replayActiveTask"npm run type-check