Skip to content

fix: provider update silently drops model_type and endpoint_url #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhenjunchen-png wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

fix: provider update silently drops model_type and endpoint_url #1628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions server/app/domains/model_provider/service/provider_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,18 @@ def update(provider_id: int, user_id: int, data: dict) -> dict:
).first()
if not model:
return {"success": False, "error_code": "PROVIDER_NOT_FOUND"}
# H10: only allow updating safe fields
_UPDATABLE_FIELDS = {"provider_name", "api_key", "api_base", "extra_config", "prefer", "is_vaild"}
# H10: only allow updating safe fields. Field names must match the
# `Provider` ORM model (and `ProviderIn` request schema) verbatim —
# `setattr(model, key, value)` silently no-ops on a missing field.
_UPDATABLE_FIELDS = {
"provider_name",
"api_key",
"model_type",
"endpoint_url",
"encrypted_config",
"prefer",
"is_vaild",
}
for key, value in data.items():
if key in _UPDATABLE_FIELDS:
setattr(model, key, value)
Expand Down