Skip to content

Conversation

@aosen-xiong
Copy link
Member

@aosen-xiong aosen-xiong commented Jul 1, 2025

Fixes #1299.

First merge #1331.

Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a draft, but some quick comments.

}

/**
* This method is almost similar to {@link
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to find a solution without this duplication.

Copy link
Member Author

@aosen-xiong aosen-xiong Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With code refactoring in #1331, we can get rid of this code duplication.

EDIT: tested at aosen-xiong#13.

@aosen-xiong aosen-xiong marked this pull request as ready for review August 28, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alias @NullMarked to mark code as annotated

2 participants