Update README.md to reflect changes in PPI Digikhata API and bank account verification API added#35
Conversation
Bumps [undici](https://github.com/nodejs/undici) from 6.21.0 to 6.21.1. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.21.0...v6.21.1) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.29.0 to 1.30.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.29.0...v1.30.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Update package.json
…undici-6.21.1 build(deps): bump undici from 6.21.0 to 6.21.1
Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.2.3 to 3.2.4. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.2.3...3.2.4) --- updated-dependencies: - dependency-name: dompurify dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.26.0 to 7.27.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…prismjs-1.30.0 build(deps): bump prismjs from 1.29.0 to 1.30.0
Bumps [redoc](https://github.com/Redocly/redoc) to 2.4.0 and updates ancestor dependency [@redocly/cli](https://github.com/Redocly/redocly-cli). These dependencies need to be updated together. Updates `redoc` from 2.2.0 to 2.4.0 - [Release notes](https://github.com/Redocly/redoc/releases) - [Changelog](https://github.com/Redocly/redoc/blob/main/CHANGELOG.md) - [Commits](Redocly/redoc@v2.2.0...v2.4.0) Updates `@redocly/cli` from 1.26.0 to 1.34.1 - [Release notes](https://github.com/Redocly/redocly-cli/releases) - [Changelog](https://github.com/Redocly/redocly-cli/blob/main/docs/changelog.md) - [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@1.26.0...@redocly/cli@1.34.1) --- updated-dependencies: - dependency-name: redoc dependency-type: indirect - dependency-name: "@redocly/cli" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…multi-24003139d1 build(deps): bump redoc and @redocly/cli
…minimist-1.2.8 build(deps): bump minimist from 1.2.5 to 1.2.8
…dompurify-3.2.4 build(deps): bump dompurify from 3.2.3 to 3.2.4
…babel/runtime-7.27.0 build(deps): bump @babel/runtime from 7.26.0 to 7.27.0
…d add new bank account verification details
There was a problem hiding this comment.
Hello @nitika1995-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the README.md file to reflect changes in the PPI Digikhata API and adds details for a new bank account verification API. The changes primarily involve updating URL endpoints to reflect the ppi-digikhata prefix and adding new parameters for the recipient bank account verification process. A new section is also added to document the Bank Account Verification API.
Highlights
- API Endpoint Updates: The pull request updates several API endpoints in the README.md file to use the
ppi-digikhataprefix, ensuring the documentation aligns with the latest API changes. Specifically, the endpoints for OTP verification, Aadhar verification, PAN verification, retrieving recipients, adding/updating recipients, adding a recipient's bank, sending transaction OTP, and initiating PPI transactions are updated. - Recipient Details: The pull request adds new parameters (
account_typeandtype) to the recipient details section, providing specific instructions for PayPoint integrations. - New Bank Account Verification API: The pull request introduces a new section documenting the Bank Account Verification API, including details on the request structure, parameters, and sample responses for successful and unsuccessful verification attempts. It also renumbers the subsequent sections.
Changelog
Click here to see the changelog
- markdown/README.md
- Updated URL endpoint for OTP verification from
/customer/account/{customer_id}/ppi/otp/verifyto/customer/account/{customer_id}/ppi-digikhata/otp/verify(line 701). - Updated URL endpoint for Aadhar verification from
/customer/account/{customer_id}/ppi/aadhaarto/customer/account/{customer_id}/ppi-digikhata/aadhaar(line 793). - Updated URL endpoint for PAN verification from
/customer/account/{customer_id}/ppi/panto/customer/account/{customer_id}/ppi-digikhata/pan(line 824). - Updated URL endpoint for retrieving recipients from
/customer/payment/ppi/sender/{customer_id}/recipientsto/customer/payment/ppi-digikhata/sender/{customer_id}/recipients(line 893). - Updated URL endpoint for adding/updating recipients from
/customer/payment/ppi/sender/{customer_id}/recipientto/customer/payment/ppi-digikhata/sender/{customer_id}/recipient(line 984). - Added
account_typeandtypeparameters with specific values for PayPoint to the recipient details section (lines 998-999). - Updated URL endpoint for adding a recipient's bank from
/customer/payment/ppi/sender/{customer_id}/bank/recipientto/customer/payment/ppi-digikhata/sender/{customer_id}/recipient/bank(line 1025). - Updated URL endpoint for sending transaction OTP from
/customer/payment/ppi/otpto/customer/payment/ppi-digikhata/otp(line 1060). - Updated URL endpoint for initiating PPI transactions from
/customer/payment/ppito/customer/payment/ppi-digikhata(line 1091). - Added a note about
beneficiary_idparameter (line 1111). - Added a new section documenting the Bank Account Verification API, including request structure and sample responses (lines 1718-1781).
- Renumbered the Bulk Bank Account Verification API section from 1.3 to 1.4 (line 1783).
- Renumbered the Bulk Bank Account Verification Status API section from 1.4 to 1.5 (line 1808).
- Renumbered the IFSC Verification API section from 1.5 to 1.6 (line 1868).
- Updated URL endpoint for OTP verification from
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A new API,
Docs updated with care,
Knowledge transfer flows.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the README.md file to reflect changes in the PPI Digikhata API and adds details for a new bank account verification API. The changes seem straightforward and necessary to keep the documentation up-to-date with the latest API developments.
Merge Readiness
The changes appear to be accurate and necessary for updating the API documentation. I don't see any immediate issues that would block merging. However, I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. Since there are no critical or high severity issues, the pull request is likely ready to be merged after another review.
|
|
||
| #### Details | ||
| - **Method:** POST | ||
| - **URL Endpoint:** /tools/kyc/bank-account/sync |
There was a problem hiding this comment.
- Need provider/brand name in URL (cashfree)
/tools/kyc/bank-account/penny-drop-cashfree - 'sync' should not be used in URL
- Other similar APIs (pennydrop & penniless) should also have provider name in them.
markdown/README.md
Outdated
| @@ -1022,7 +1024,7 @@ Use this API to add a recipient's bank. | |||
|
|
|||
There was a problem hiding this comment.
### 2.3 Register Recipient With Bank API
Use this API to register a recipient with the bank, before they are allowed to receive payments via PPI.
…d add new bank account verification details
…ification' into feat/updatePPIURL-bankaccountverification
…d add new bank account verification details
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
🚨 Checklist:
Further comments
🙏 Thank you!
Thank you for contributing to this project. We appreciate your time and effort. 🎉