Conversation
Add --auth-token CLI option to include Bearer authentication in gRPC requests. Supports both command line argument and SSHX_AUTH_TOKEN environment variable. This enables integration with authentication systems that require tokens to be passed in the Authorization header for both session creation and cleanup. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
|
I see this fails CI. Since it only touches client code, it's good in its current form. However, if you want me to include another commit, I can add the Controller::new calls to include the auth_token. Thanks! I have included a diff of the proposed fix: |
|
@ekzhang I am not sure if you have any comments on this. Let me know, be good to get this upstreamed, otherwise I'll have to build sshx locally :). |
|
Ah yes this makes sense, we could do this. Technically self-hosting is not supported, but it seems like the bare minimum sshx could offer to help. Thanks for implementing! |
|
I should change the API a bit so it doesn't break CI, and also add validation to the server |
|
@ekzhang, no problem. It would be awesome to have it upstreamed soon if possible! Yes, I understand. I'll leave it with you. Let me know if you want me to make any changes. Thanks for a great project! |
|
@ekzhang, can we get this through, do you think? |
|
any updates? |
Add --auth-token CLI option to include Bearer authentication in gRPC requests. Supports both command line argument and SSHX_AUTH_TOKEN environment variable.
This enables integration with authentication systems that require tokens to be passed in the Authorization header for both session creation and cleanup.