Skip to content

tests/contrib/django: use proper mock#2599

Merged
xrmx merged 2 commits intoelastic:mainfrom
xrmx:fix-mock-in-django-tests
Apr 8, 2026
Merged

tests/contrib/django: use proper mock#2599
xrmx merged 2 commits intoelastic:mainfrom
xrmx:fix-mock-in-django-tests

Conversation

@xrmx
Copy link
Copy Markdown
Member

@xrmx xrmx commented Apr 8, 2026

What does this pull request do?

The read mock should take at least an argument. Fixes:

tests.contrib.django.fixtures.TempStoreClient:client.py:151
  Can't capture request body: test_post_read_error_logging.<locals>.read()
  takes 0 positional arguments but 1 was given

Assisted-by: Cursor

Related issues

The read mock should take at least an argument. Fixes:

tests.contrib.django.fixtures.TempStoreClient:client.py:151
  Can't capture request body: test_post_read_error_logging.<locals>.read()
  takes 0 positional arguments but 1 was given

Assisted-by: Cursor
@xrmx xrmx requested a review from a team as a code owner April 8, 2026 13:59
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@xrmx xrmx enabled auto-merge (squash) April 8, 2026 14:07
Copy link
Copy Markdown

@hegerchr hegerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xrmx xrmx merged commit f35364c into elastic:main Apr 8, 2026
263 of 269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants