Skip redirect validation for docset-excluded paths#3095
Conversation
ValidateRedirects now uses Configuration.IsExcluded (docset globs, folder TOC excludes, include overrides) so deleted or renamed Markdown under excluded trees does not require redirects.yml entries. Adds ConfigurationFileExcludeTests for Elasticsearch-style exclude globs. Made-with: Cursor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Comment |
Summary
docs-builder validate(redirect validation) requiredredirects.ymlentries for every deleted or renamed Markdown file, without consideringdocset.ymlexcludeglobs or folder-level TOC excludes. That caused false positives when paths were never published (for example Elasticsearch excluding generated Kibana ES|QL docs underreference/query-languages/esql/kibana/docs/**).Changes
LocalChangeTrackingService.ValidateRedirects: Before checkingredirects.yml, skip changes whose docset-relative path matchesConfiguration.IsExcluded(same logic as the Markdown pipeline: docset globs,FolderExcludedFiles, and!include overrides).ConfigurationFileExcludeTestscovers the Elasticsearch-style glob and a path outside the excluded tree.Testing
dotnet builddotnet test tests/Elastic.Documentation.Configuration.Tests/Made with Cursor