Skip to content

Improve formatting and update deps#41

Open
pugnascotia wants to merge 3 commits into
elastic:mainfrom
pugnascotia:improve-formatting-update-deps
Open

Improve formatting and update deps#41
pugnascotia wants to merge 3 commits into
elastic:mainfrom
pugnascotia:improve-formatting-update-deps

Conversation

@pugnascotia
Copy link
Copy Markdown
Collaborator

Update all dependencies (except peggy and ts-pegjs) and migrate the ESLint config.

The ESLint config now always requires curly braces. This makes logic branches more obvious.

The PEG libraries haven't been updated because ts-pegjs is essentially out-of-date, and updating just peggy creating incompatibility warnings. There is an alternative called peggy-ts, but it isn't released to NPM and using it doesn't result in any beneficial changes.

Copy link
Copy Markdown
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, just one small comment

Comment thread .github/workflows/node.js.yml Outdated
@pugnascotia pugnascotia force-pushed the improve-formatting-update-deps branch from 83a085c to 0ba98f7 Compare June 2, 2026 12:30
@pugnascotia pugnascotia requested a review from sabarasaba June 2, 2026 12:31
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants