Skip to content

Updates the flow metrics view in Logstash's diagnostic creation #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pickypg merged 5 commits into from
Apr 15, 2026
+90 −4
Merged

Updates the flow metrics view in Logstash's diagnostic creation #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ef4ef8
Updates the flow metrics view in Logstash's diagnostic creation to in…
andsel Mar 10, 2026
c8ce5c6
Conditionally display the batch structure metrics panel
andsel Mar 26, 2026
2664af7
Selectively display p50 and p90 group columns of if present
andsel Mar 26, 2026
6e82618
Removed runApplication utility task for dev
andsel Mar 26, 2026
657cfc4
Fixed name of task to run in Gradle to build
andsel Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,8 @@ This software is licensed under [Elastic License v2](https://www.elastic.co/lice
- Clone or download the Github repo. In order to clone the repo you must have Git installed and running. See the instructions appropriate for your operating system.
- Make sure you have a JDK version 17 or greater. It **must** be a JDK, not a JRE or you will not be able to compile.
- Set the `JAVA_HOME` environment variable to point to your JDK installation.
- Make sure a recent version of Maven is installed on the build machine.
- Create a `MAVEN_HOME` directory pointing to the location you've unzipped it to.
- `cd` to the top level repo directory and type `mvn package`.
- The release artifacts will be contained in the `target` directory.
- `cd` to the top level repo directory and type `./gradlew build`.
- The release artifacts will be contained in the `build/libs` directory.

### Creating A Docker Image

Expand Down
88 changes: 88 additions & 0 deletions src/main/resources/logstash-diagnostic-templates/flow_metrics.html.ftlh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,11 @@
};
}

const hasBatchP50 = _try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p50) !== ""
|| _try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50) !== "";
const hasBatchP90 = _try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p90) !== ""
|| _try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90) !== "";

return (
<Stack spacing={2}>
<Stack direction="row" spacing={1} alignItems="center" justifyContent="flex-start" sx={{paddingBottom: 1, paddingTop: 1}}>
Expand Down Expand Up @@ -833,6 +838,89 @@
</Stack>
</CardContent>
</Card>

{_try(() => data.stats.pipelines[selectedPipeline.name].batch) && (
<Card variant="outlined" sx={{
Comment thread
andsel marked this conversation as resolved.
height: '100%',
border: 'inherited',
borderColor: theme.palette.primary[200] + 75,
':hover': {
boxShadow: '0 2px 14px 0 rgb(32 40 45 / 8%)'
}
}}>
<CardHeader title={<Typography
sx={{flex: '1 1 100%'}}
variant="h7"
component="div"
color="text.secondary"
>
Batch structure
</Typography>} />
<Divider />
<CardContent >
<TableContainer>
<Table size="small" aria-label="Batch structure">
<TableHead>
<TableRow>
<TableCell>Metric</TableCell>
<TableCell align="right">Current</TableCell>
<TableCell align="right">Average</TableCell>
{hasBatchP50 && <TableCell align="center" colSpan={3}>p50</TableCell>}
{hasBatchP90 && <TableCell align="center" colSpan={3}>p90</TableCell>}
</TableRow>
<TableRow>
<TableCell />
<TableCell align="right" />
<TableCell align="right" />
{hasBatchP50 && <React.Fragment>
<TableCell align="right">1 min</TableCell>
<TableCell align="right">5 min</TableCell>
<TableCell align="right">15 min</TableCell>
</React.Fragment>}
{hasBatchP90 && <React.Fragment>
<TableCell align="right">1 min</TableCell>
<TableCell align="right">5 min</TableCell>
<TableCell align="right">15 min</TableCell>
</React.Fragment>}
</TableRow>
</TableHead>
<TableBody>
<TableRow>
<TableCell component="th" scope="row">Event count</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.current)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.average.lifetime)}</TableCell>
{hasBatchP50 && <React.Fragment>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p50.last_1_minute)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p50.last_5_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p50.last_15_minutes)}</TableCell>
</React.Fragment>}
{hasBatchP90 && <React.Fragment>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p90.last_1_minute)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p90.last_5_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p90.last_15_minutes)}</TableCell>
</React.Fragment>}
</TableRow>
<TableRow>
<TableCell component="th" scope="row">Byte size</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.current)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.average.lifetime)}</TableCell>
{hasBatchP50 && <React.Fragment>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50.last_1_minute)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50.last_5_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50.last_15_minutes)}</TableCell>
</React.Fragment>}
{hasBatchP90 && <React.Fragment>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90.last_1_minute)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90.last_5_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90.last_15_minutes)}</TableCell>
</React.Fragment>}
</TableRow>
</TableBody>
</Table>
</TableContainer>
</CardContent>
</Card>
)}
</Paper>
<SelectedPipelinePluginAnalysisTable selectedPipeline={selectedPipeline}
analysisWindow={analysisWindow}
Expand Down
Loading