Open
Conversation
Contributor
|
A small improvement all alert having same name FalcoAlert if multiple are firing simultaneously they might override each other. Probably we add some priority to the alert name to be different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-changeorkind/dev-changedepending on typeCritical security fixes should be marked with
kind/securityWhat does this PR do / why do we need this PR?
These changes enable Falco rule priorities to be mapped to severity levels, which are then translated into P1, P2 etc., in OpsGenie. This is done by creating alerts based on Falco rule priority and assigning a
severitylabel with the corresponding value. Any additional priorities introduced in the future will need to follow the same configuration, with matching alerts and severity levels.One suggestion has been to explore using Falcosidekick directly with Alertmanager. If this solution is adopted, manual priority-to-severity mapping would no longer be necessary, as priorities can then be mapped to severities using the
customseveritymap.Information to reviewers
Checklist